Kalle Valo <kvalo@xxxxxxxxxxxxxxxx> writes: > Sujith Manoharan <sujith@xxxxxxxxxxx> writes: > >> Joe Perches wrote: >>> Perhaps it would be reasonable to create and use standardized >>> logging ath_<level> functions for all the device ath<x>k_<level>s. >> >> Indeed. >> >> You already did that in "ath: Add and use ath_printk and ath_<level>" :) > > IIRC Sujith actually suggested this to me already earlier, but I didn't > buy the idea even then. ath9k and ath10k are very different, so we > cannot share all the debug levels. I just feel that it restricts and > confuses the driver debugging too much, and all just to save something > like 100 lines of code. I'm having hard time to see why bother. I also noticed that ath.h doesn't support tracing. I would hate to lose that. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html