On Mon, May 13, 2013 at 11:14 PM, Tetsuo Tatsugami <tatsugami-txa@xxxxxxxxxxxxxxx> wrote: > Dear mcgrof, > > My name is Tetsuo Tatsugami. > I work for NEC CASIO Mobile communications, Ltd. > We are using Qualcomm APQ 8064 chipset in our device. > > We requested the modification of crda to Qualcomm support team, > and they said that I could send the patches to you. > Because the crda is open source code. > > > Our modification for crda: > The crda is executed by root user to use netlink socket. > It's better to minimize the capabilities for security reason. > The crda can work if it has CAP_NET_ADMIN capabilities. > > I attached the patch in this mail. > It worked well in our device. Tetsuo, thanks so much for the patch but unfortunately in order to facilitate patch review we need developers to engage with the community through our standard practice of submitting patches inline in ASCII text, not as attachments. Its also encouraged if you have multiple patches that you enumerate them and also provide a good commit log message. As for CRDA we also use the DCO so be sure to read the DCO and then if you agree be sure to add the Signed-off-by tag to each patch. This git guide is specific to 802.11 Linux wireless kernel development but it contains sufficient examples of how to configure git, ssmtp, etc to help you get patches out to me and the community that enables community review: http://wireless.kernel.org/en/developers/Documentation/git-guide Please let me know if you have any questions. I cannot stress the importance of a good commit log message. If in doubt just check git log on the project for other holder commit log messages for examples. Can you resend with git format-patch ? Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
