On Jan 29, 2008 4:05 PM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > > > Also inserting few, actually drawing it unusable. You are lucky we > > like you here :) > > The question is how we handle this?. Do you want to resubmit this > > huge patch or we fix it somehow over it... > > Can you point out any bugs? It works with my iwl4965 card (and the fix > for the unfortunate bug for the scanning problem). > 1. As I wait box we lost scanning in A mode, we have WARN_ON(1) on every RX packet now because of invalid rate 2. There are few sparse bugs if you run it - don't remember exactly 3. HT doesn't compile bug this I want to fix over HT AGG patches 4. Few problems in code I spotted but there are probably many For example in RX path rate_idx = iwl4965_hw_get_rate( le32_to_cpu(rx_start->rate_n_flags)), This is wrong 1. the le_to_cpu is redundant (it's aleardy done in hw) 2. it will give you rate in plcp format and not the index I rather do better review of this... first I want to put this patch above HT agg patches Thanks Tomas > johannes > - To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
