Search Linux Wireless

Re: [PATCH] mac80211: clean up mesh RCU warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2013-05-02 at 16:11 -0700, Thomas Pedersen wrote:
> When running a kernel with CONFIG_PROVE_RCU, the minstrel
> rate update code would complain about being called without
> the RCU read lock held. This is because
> mesh_sta_info_init() may or may not have been called under
> RCU read lock. Perform some bureaucratic critical section
> toggling to always call mesh_sta_info_init() under RCU,
> and silence this warning.

This was discussed in another thread a while ago, but unfortunately
nothing came out of it. I really don't think this is the right solution,
since the code that this calls doesn't even use rcu_dereference()
properly.

Felix, please come up with a proper fix soon, otherwise I'm going to
revert your changes for 3.10.

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux