On Mon, 2008-01-28 at 17:25 +0100, Holger Schurig wrote:
> see subject
>
> Signed-off-by: Holger Schurig <hs4233@xxxxxxxxxxxxxxxxxxxx>
>
> Index: wireless-2.6/drivers/net/wireless/libertas/cmd.c
> ===================================================================
> --- wireless-2.6.orig/drivers/net/wireless/libertas/cmd.c 2008-01-22 12:47:50.000000000 +0100
> +++ wireless-2.6/drivers/net/wireless/libertas/cmd.c 2008-01-22 16:36:02.000000000 +0100
> @@ -1182,9 +1182,9 @@ static void lbs_submit_command(struct lb
> command == CMD_802_11_AUTHENTICATE)
> timeo = 10 * HZ;
>
> - lbs_deb_host("DNLD_CMD: command 0x%04x, seq %d, size %d, jiffies %lu\n",
> + lbs_deb_cmd("DNLD_CMD: command 0x%04x, seq %d, size %d, jiffies %lu\n",
> command, le16_to_cpu(cmd->seqnum), cmdsize, jiffies);
> - lbs_deb_hex(LBS_DEB_HOST, "DNLD_CMD", (void *) cmdnode->cmdbuf, cmdsize);
> + lbs_deb_hex(LBS_DEB_CMD, "DNLD_CMD", (void *) cmdnode->cmdbuf, cmdsize);
>
> ret = priv->hw_host_to_card(priv, MVMS_CMD, (u8 *) cmd, cmdsize);
>
> @@ -1193,9 +1193,7 @@ static void lbs_submit_command(struct lb
> /* Let the timer kick in and retry, and potentially reset
> the whole thing if the condition persists */
> timeo = HZ;
> - } else
> - lbs_deb_cmd("DNLD_CMD: sent command 0x%04x, jiffies %lu\n",
> - command, jiffies);
> + }
>
> /* Setup the timer after transmit command */
> mod_timer(&priv->command_timer, jiffies + timeo);
> @@ -1214,7 +1212,7 @@ static int lbs_cmd_mac_control(struct lb
> cmd->size = cpu_to_le16(sizeof(struct cmd_ds_mac_control) + S_DS_GEN);
> mac->action = cpu_to_le16(priv->currentpacketfilter);
>
> - lbs_deb_cmd("MAC_CONTROL: action 0x%x, size %d\n",
> + lbs_deb_cmd("MAC_CONTROL: action 0x%04x, size %d\n",
> le16_to_cpu(mac->action), le16_to_cpu(cmd->size));
>
> lbs_deb_leave(LBS_DEB_CMD);
> @@ -2068,15 +2066,15 @@ int lbs_cmd_copyback(struct lbs_private
> struct cmd_header *buf = (void *)extra;
> uint16_t copy_len;
>
> - lbs_deb_enter(LBS_DEB_CMD);
> + //lbs_deb_enter(LBS_DEB_CMD);
>
> copy_len = min(le16_to_cpu(buf->size), le16_to_cpu(resp->size));
> - lbs_deb_cmd("Copying back %u bytes; command response was %u bytes, "
> - "copy back buffer was %u bytes\n", copy_len,
> - le16_to_cpu(resp->size), le16_to_cpu(buf->size));
> + //lbs_deb_cmd("copying %u bytes; respsize %u, "
> + // "bufsize %u\n", copy_len,
> + // le16_to_cpu(resp->size), le16_to_cpu(buf->size));
> memcpy(buf, resp, copy_len);
>
> - lbs_deb_leave(LBS_DEB_CMD);
> + //lbs_deb_leave(LBS_DEB_CMD);
> return 0;
> }
If you want to kill them, let's remove them. // also doesn't conform to
the kernel style. I'd say just take the debug bits out for now.
Dan
> EXPORT_SYMBOL_GPL(lbs_cmd_copyback);
> Index: wireless-2.6/drivers/net/wireless/libertas/cmdresp.c
> ===================================================================
> --- wireless-2.6.orig/drivers/net/wireless/libertas/cmdresp.c 2008-01-22 14:38:34.000000000 +0100
> +++ wireless-2.6/drivers/net/wireless/libertas/cmdresp.c 2008-01-22 16:43:54.000000000 +0100
> @@ -509,9 +509,9 @@ int lbs_process_rx_command(struct lbs_pr
> respcmd = le16_to_cpu(resp->command);
> result = le16_to_cpu(resp->result);
>
> - lbs_deb_host("CMD_RESP: response 0x%04x, seq %d, size %d, jiffies %lu\n",
> + lbs_deb_cmd("CMD_RESP: response 0x%04x, seq %d, size %d, jiffies %lu\n",
> respcmd, le16_to_cpu(resp->seqnum), priv->upld_len, jiffies);
> - lbs_deb_hex(LBS_DEB_HOST, "CMD_RESP", (void *) resp, priv->upld_len);
> + lbs_deb_hex(LBS_DEB_CMD, "CMD_RESP", (void *) resp, priv->upld_len);
>
> if (resp->seqnum != resp->seqnum) {
> lbs_pr_info("Received CMD_RESP with invalid sequence %d (expected %d)\n",
-
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
