Re: [PATCH 2/7] rt2x00: rt61pci: use rt2x00dev->tx->limit

[Gertjan van Wingerde <gwingerde@xxxxxxxxx>]

On Wed, May 1, 2013 at 5:17 PM, Gabor Juhos <juhosg@xxxxxxxxxxx> wrote:
> The TX data queue is initialized already when
> the rt61pci_txdone() function is called.
>
> Fetch the number of the queue entries from that
> instead of using the entry_num field of the data
> queue descriptor.
>
> The two values are the same, and the use of the
> rt2x00dev->tx->limit value allows us to get rid
> of a superfluous pointer dereference.
>
> Signed-off-by: Gabor Juhos <juhosg@xxxxxxxxxxx>

Acked-by: Gertjan van Wingerde <gwingerde@xxxxxxxxx>

> ---
>  drivers/net/wireless/rt2x00/rt61pci.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt61pci.c b/drivers/net/wireless/rt2x00/rt61pci.c
> index 0dc8180..7e1759b 100644
> --- a/drivers/net/wireless/rt2x00/rt61pci.c
> +++ b/drivers/net/wireless/rt2x00/rt61pci.c
> @@ -2175,7 +2175,7 @@ static void rt61pci_txdone(struct rt2x00_dev *rt2x00dev)
>          * that the TX_STA_FIFO stack has a size of 16. We stick to our
>          * tx ring size for now.
>          */
> -       for (i = 0; i < rt2x00dev->ops->tx->entry_num; i++) {
> +       for (i = 0; i < rt2x00dev->tx->limit; i++) {
>                 rt2x00mmio_register_read(rt2x00dev, STA_CSR4, &reg);
>                 if (!rt2x00_get_field32(reg, STA_CSR4_VALID))
>                         break;
> --
> 1.7.10
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



--
---
Gertjan
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html