Am 29.04.2013 08:45, schrieb Wojciech Dubowik:
On 04/28/2013 05:03 PM, Oleksij Rempel wrote:
Am 28.04.2013 16:13, schrieb Oleksij Rempel:
Am 28.04.2013 14:51, schrieb Felix Fietkau:
On 2013-04-27 5:25 PM, Oleksij Rempel wrote:
Collect statistics about recived duplicate and STBC packets.
This information should help see if STBC is actually working.
Tested on ar9285;
Signed-off-by: Oleksij Rempel <linux@xxxxxxxxxxxxxxxx>
I thought about this patch some more, and I'm wondering what's the
point
in doing this? These statistics are going to be completely useless for
most people and they'll waste some memory/cpu cycles, especially on
small-cache devices. I think it's much more useful to simply pass the
information to mac80211 via rx flags and get them added to the radiotap
header.
Sure.
I see Wojciech Dubowik sanded some patches, for at least one year, to
make exactly what Felix suggested. Are there any reason why this
patches was not accepted?
Wojciech if you alive and have some time, can you update them?
Sure. I will try to update them based on suggested radiotap field
structure for STBC and Ness.
On the other hand as Felix already mentioned it's yet another line of
code one needs once in a lifetime.
If one is checking whether stbc is working the easiest way is to create
own debugging namespace
in radiotap and dump all descriptor registers there. It probably doesn't
go mainline but you could apply
the patches when you need and they mostly rebase cleanly. At least
that's what I do.
Felix,
will this patches go upstream if i make it raditap compatible?
If yes, and performance and cache usage is an issue, it think we should
remove this double flags mapping in ath9k. Currently we convert device
specific flags to driver flags, and then convert them to mac80211 flags.
There is lots of useless checks and conversations for each packet.
Should i change it?
--
Regards,
Oleksij
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
