Johannes Berg <johannes@xxxxxxxxxxxxxxxx> writes: > On Wed, 2013-04-24 at 13:11 +0300, Kalle Valo wrote: >> Johannes Berg <johannes@xxxxxxxxxxxxxxxx> writes: >> >> > +#ifndef CONFIG_CFG80211_ANDROID_P2P_HACK >> > if (WARN_ON(wdev->netdev)) >> > return; >> > +#endif >> >> With my favorite kernel macro, config_enabled(), you could get rid of >> quite a lot of the ugly ifdefs. > > Yeah, but as long as this isn't going upstream I don't really want to > though since then it touches the code and is less obvious. Anyway we'll > see. Ah, makes send. FWIW, I think we should push this, and other wireless Android support, upstream. We should first get them to use upstream interfaces and then start fixing the problematic areas one by one. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
