Hi Larry, thanks. I've prepared below (simple) patch just adding
initialization list and what Joe's patch does.
Is this ok?
H.
Signed-off-by: Han Shen (shenhan@xxxxxxxxxx)
---
drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c
b/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c
index b793a65..34150de 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c
@@ -669,7 +669,7 @@ static void
rtl92c_dm_txpower_tracking_callback_thermalmeter(struct ieee80211_hw
u8 thermalvalue, delta, delta_lck, delta_iqk;
long ele_a, ele_d, temp_cck, val_x, value32;
long val_y, ele_c = 0;
- u8 ofdm_index[2], ofdm_index_old[2], cck_index_old = 0;
+ u8 ofdm_index[2], ofdm_index_old[2] = {0, 0}, cck_index_old = 0;
s8 cck_index = 0;
int i;
bool is2t = IS_92C_SERIAL(rtlhal->version);
@@ -717,7 +717,7 @@ static void
rtl92c_dm_txpower_tracking_callback_thermalmeter(struct ieee80211_hw
for (i = 0; i < OFDM_TABLE_LENGTH; i++) {
if (ele_d == (ofdmswing_table[i] &
MASKOFDM_D)) {
-
+ ofdm_index_old[1] = (u8) i;
RT_TRACE(rtlpriv, COMP_POWER_TRACKING,
DBG_LOUD,
"Initial pathB ele_d reg0x%x = 0x%lx, ofdm_index=0x%x\n",
--
1.8.2.1
On Fri, Apr 12, 2013 at 5:42 PM, Larry Finger <Larry.Finger@xxxxxxxxxxxx> wrote:
> On 04/12/2013 05:20 PM, Han Shen(沈涵) wrote:
>>
>> Hi, Joe's patch (the 1-line fix) does not work for me. The assignment
>> is in a conditional block, when refer to this ofdm_index_old later, I
>> still get error -
>>
>>
>> /mnt/host/source/src/third_party/kernel/files/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c:771:31:
>> error: 'ofdm_index_old[1]' may be used uninitialized in this function
>> [-Werror=maybe-uninitialized]
>> rtlpriv->dm.ofdm_index[i] = ofdm_index_old[i];
>>
>> (I'm working on 3.4 branch.)
>
>
> I would get rid of the -Werror=maybe-unitialized. Sometimes gcc generates a
> false warning, and you really should not error the build in that case.
>
> The correct patch needs to initialize the array to 0, and set the element
> the way Joe's patch does.
>
> Larry
>
>
--
Han Shen | Software Engineer | shenhan@xxxxxxxxxx | +1-650-440-3330
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
