Search Linux Wireless

Re: vht off-by-one nss

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Apr 15, 2013 at 02:47:55PM +0200, Johannes Berg wrote:
> On Mon, 2013-04-15 at 14:33 +0200, Karl Beldan wrote:
> 
> > > > +++ b/net/mac80211/cfg.c
> > > > @@ -389,7 +389,7 @@ void sta_set_rate_info_tx(struct sta_info *sta,
> > > >  	} else if (rate->flags & IEEE80211_TX_RC_VHT_MCS) {
> > > >  		rinfo->flags |= RATE_INFO_FLAGS_VHT_MCS;
> > > >  		rinfo->mcs = ieee80211_rate_get_vht_mcs(rate);
> > > > -		rinfo->nss = ieee80211_rate_get_vht_nss(rate);
> > > > +		rinfo->nss = ieee80211_rate_get_vht_nss(rate) + 1;
> > > >  	} else {
> > > >  		struct ieee80211_supported_band *sband;
> > > >  		sband = sta->local->hw.wiphy->bands[
> > > > }
> > > 
> > > 
> > > Wouldn't this one also require an update for VHT radiotap in
> > > net/mac80211/rx.c around line 320 (RX_FLAG_VHT)?
> > > 
> > The radiotap field is set with ieee80211_rx_status.vht_nss, so no need.
> 
> And that's properly 1-based, rather than 0-based like in TX info? I
> guess I forgot all of this already, heh.
> 
ieee80211_rx_status.vht_nss asks for a 1-based field but it is set by
drivers .. and since no driver report any (yet) .. anyways, I'll send a
patch along with it for mac80211_hwsim .. that can serve as a reminder ;).

 
Karl
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux