Hi Troy,
Thanks for reviewing.
> > - priv->curr_bss_params.bss_descriptor.disable_11ac = true;
> > -
>
> Should the = true line be moved below the memcpy? Your way produces
> the same behavior, but was it buggy before?
"bss_descriptor.disable_11ac = true" shouldn't be set after memcpy, because bss_desc->disable_11ac reflects the associated AP's 11ac setting here.
Perhaps we should set "bss_desc->disable_11ac = true" earlier before parsing AP's beacon IE?
@@ -184,6 +184,8 @@ int mwifiex_fill_new_bss_desc(struct mwifiex_private *priv,
else
bss_desc->bss_mode = NL80211_IFTYPE_STATION;
+ bss_desc->disable_11ac = true;
+
return mwifiex_update_bss_desc_with_ie(priv->adapter, bss_desc);
}
This flag can be reset to false if AP's beacon does advertise 11ac support.
Yogesh, any thoughts?
We had offline discussion on replacing disable_11ac with existing VHT flags.
Maybe initializing it in mwifiex_fill_new_bss_desc() is way to go?
Thanks,
Bing
> > /* Make a copy of current BSSID descriptor */
> > memcpy(&priv->curr_bss_params.bss_descriptor, bss_desc,
> > sizeof(priv->curr_bss_params.bss_descriptor));
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
