On Mon, Apr 8, 2013 at 11:37 AM, Johannes Berg
<johannes@xxxxxxxxxxxxxxxx> wrote:
> On Mon, 2013-04-08 at 11:06 -0700, Thomas Pedersen wrote:
>> Have ieee80211_queue_stopped() return a bitmap of enum
>> queue_stop_reasons while checking queue status. This is
>> handy when we care about the queue stop reason codes.
>
> Nack. The driver must not care about the reasons, they're purely
> internal to mac80211.
OK those functions are exported to the drivers. The 'enum
queue_stop_reason' is defined in ieee80211_i.h, so the driver wouldn't
be able to interpret them anyway?
Would you prefer a utility function internal to mac80211 which does
return the reason, or just the following pattern?
if (ieee80211_queue_stopped(hw, queue)) {
qreason = hw_to_local(hw)->queue_stop_reasons[queue];
if (qreason & ~(ALLOWED_QUEUE_STOP_REASONS))
something;
}
Thanks,
--
Thomas
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
