Hi Andi, > If I run: checkpatch.pl -f drivers/net/wireless/mwifiex/wmm.c. I > get about 10-20 similar warnings. In general it seems mwifiex > sticks with type 1 multiline comments. And I wanted to stick with > the de-facto standard. > > Should I still fix the warning? Yes. Please fix the warning in these 2 patches. Also there are some other warnings: CHECK: Blank lines aren't necessary before a close brace '}' #154: FILE: drivers/net/wireless/mwifiex/wmm.c:935: You have to use "--strict" option to spot these messages. > Should I prepare a separate patch on top fixing all multiline > comments? I think that will be too much in the entire driver code. Let's keep them for now. [...] > > Could you share what test cases you are running? I will try to cover the cases you have not done. > > Duration test with high load, sender and receiver. > > I have dualband router and two DUT. One DUT connects to > 2.4GHz-band the other to 5GHz-band. One is running iperf as > server the other iperf as a client in a while true loop. > > Eventually I will switch over to set one DUT as uAP, but didn't > play with uAP yet. Thanks for the information. Regards, Bing -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
