On Saturday 26 January 2008 04:05:34 Stefano Brivio wrote:
> From: Larry Finger <larry.finger@xxxxxxxxxxxx>
>
> Add a sanity check in rate_control_pid_adjust_rate(). Thanks to Larry Finger
> for suggesting this and reporting a related bug.
>
> Signed-off-by: Stefano Brivio <stefano.brivio@xxxxxxxxx>
> NOT-Signed-off-by: Larry Finger <larry.finger@xxxxxxxxxxxx>
> ---
> Index: wireless-2.6/net/mac80211/rc80211_pid_algo.c
> ===================================================================
> --- wireless-2.6.orig/net/mac80211/rc80211_pid_algo.c
> +++ wireless-2.6/net/mac80211/rc80211_pid_algo.c
> @@ -128,6 +128,11 @@ static void rate_control_pid_adjust_rate
> }
>
> newidx += back;
> +
> + if (newidx < 0 || newidx >= sband->n_bitrates) {
> + WARN_ON(1);
> + break;
> + }
> }
Just you know, you can also do this kind of check this way:
if (WARN_ON(newidx < 0 || newidx >= sband->n_bitrates))
break;
This way you have an implicite unlikely() and less lines. :)
But you don't need to respin the patch. I'm also OK with the above.
This is just informational. ;)
--
Greetings Michael.
-
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
