On Fri, Apr 05, 2013 at 11:02:22PM +0200, Stanislaw Gruszka wrote: > On Fri, Apr 05, 2013 at 05:26:37PM +0200, Gabor Juhos wrote: > > 2013.04.05. 15:32 keltezéssel, Stanislaw Gruszka írta: > > > On Fri, Apr 05, 2013 at 08:27:01AM +0200, Gabor Juhos wrote: > > >> Use the recently introduced rt2x00mmio_* routines > > >> instead of the rt2x00pci_* variants. > > >> > > >> The patch contains no functional changes. > > >> > > >> Signed-off-by: Gabor Juhos <juhosg@xxxxxxxxxxx> > > >> --- > > >> drivers/net/wireless/rt2x00/rt2400pci.c | 309 ++++++++++++++++--------------- > > > > > > Why do you modify rt2400pci ? > > > > Because the rt2x00pci_* functions provided by the rt2x00mmio module has been > > renamed in the first patch and those are using the rt2x00mmio_ prefix now. The > > rt2x00mmio.h header provides definitions for the old function names but those > > definitions are removed by the last patch. > > Ah, ok, but this breaks compilation. This should be avoided, to do not > break bisection. Hance patches should be merged into one or incremental > changes proposed that do not break compilation. Otherwise changes look > ok for me. Nevermind, you provided those compat defines, so compilation do not break. ACK for set. Stanislaw -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
