On Fri, 2013-04-05 at 10:39 +0200, Antonio Quartulli wrote: > In the batman-adv module (which implements a routing protocol for mesh networks > on layer 2) we are trying to switch metric from packet loss to throughput and > the idea is to read the estimation from the rate control component (thanks to > the API mechanism in cfg/mac80211 this can be eventually changed later). While this makes some sense, going into the details of your patchset I find that it's overly complex. I think you should fix minstrel to report the best rate in txrc.reported_rate. This would also have the effect of not showing sampling attempts to userspace in the "current TX rate", which generally makes a lot of sense. After doing that, reading the rate becomes a get_station_info() call or so. One more detail: int cfg80211_get_max_tp(struct wireless_dev *wdev, u8 *peer, u32 *tp) I really don't think that the wireless_dev should be necessary for this, it ought to be just a netdev IMHO. Also, the peer should be const :) johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
