Search Linux Wireless

RE: [PATCH 4/4] mwifiex: bug: hold proper locks when accessing ra_list / bss_prio lists.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Andi,

> @@ -981,6 +973,12 @@ mwifiex_wmm_get_highest_priolist_ptr(struct mwifiex_adapter *adapter,
>  						    struct mwifiex_ra_list_tbl,
>  						    list);
>  				} while (ptr != head);
> +
> +skip_wmm_queue:
> +				spin_unlock_irqrestore(&priv_tmp->wmm.
> +						       ra_list_spinlock,
> +						       flags_ra);
> +

Please remove this blank line.

>  			}
> 
>  skip_bss:
> @@ -998,14 +996,21 @@ skip_bss:
>  						struct mwifiex_bss_prio_node,
>  						list);
>  		} while (bssprio_node != bssprio_head);
> +
> +skip_prio_tbl:
> +		spin_unlock_irqrestore(&adapter->bss_prio_tbl[j].bss_prio_lock,
> +				       flags_bss);
> +

Please remove this blank line.

>  	}
>  	return NULL;
> 
>  found:
> -	spin_lock_irqsave(&priv_tmp->wmm.ra_list_spinlock, flags);
> +	/* holds bss_prio_lock / ra_list_spinlock */

Thanks,
Bing

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux