On Fri, 2013-03-22 at 08:59 -0700, Ben Greear wrote: > On 03/22/2013 03:28 AM, Johannes Berg wrote: > > On Tue, 2013-03-19 at 14:19 -0700, greearb@xxxxxxxxxxxxxxx wrote: > >> From: Ben Greear <greearb@xxxxxxxxxxxxxxx> > >> > >> After that, print it out with net_ratelimit. We saw a system > >> continually hit this warning, for reasons unknown, and it > >> seems it bogged the system down enough to make it go OOM. > > > > I'm not really sure I like this ... that points to a deeper problem, and > > this just papers over it while causing more cost in the TX path for all > > the different checks. > > If I add an 'unlikely' to the initial check, that gets back to the original > TX path cost, or are you worried about something else? > > I think in most cases we should be using some variation of WARN_ONCE > in all the places that splat a warning... Let's just make this WARN_ONCE() then maybe? johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
