On Friday 25 January 2008 22:46:26 John W. Linville wrote: > On Fri, Jan 25, 2008 at 10:21:07PM +0100, Michael Buesch wrote: > > On Friday 25 January 2008 22:11:44 Inaky Perez-Gonzalez wrote: > > > On Friday 25 January 2008, Michael Buesch wrote: > > > > On Friday 25 January 2008 19:34:46 Linus Torvalds wrote: > > > > > My attitude is: CPU's that do unaligned accesses right are the *good* > > > > > CPU's. We should encourage them, and put the onus of being crap on the > > > > > ones that are crap, rather than penalizing the ones that aren't. > > > > > > > > I absolutely agree. But as this can get fixed with _no_ performance loss > > > > at all inside of the firmware (and who if not intel can change stuff > > > > in their firmware?), I think this warning is in fact valid. > > > > > > Well, you forgot the point that maybe it is not that simple to get such > > > a seemingly simple change into the firmware for a long list of reasons. > > > > The reasons being? > > Firmware certification is expensive. > > Plus it is a bit unfair to ask for firmware changes just because the > vendor is actually engaged with us. If this were Broadcom or Zydas > firmware we would have little recourse other than to accept it or > fix it in the driver or stack. Well, we could patch broadcom's firmware ;) But anyway. So what about removing the WARN_ON() and replacing it by a conditional memmove then? I mean, the wireless hardware I care about already is sane or fixed. So if intel doesn't want to support this kind of machines, I'd say in the end it is OK and we should not care about it at all. I mean, nobody is forced to buy an intel card to use on such a machine. I must say I don't care much about intel's customers that want to run intel wireless in a machine that can't do unaligned access, if intel itself doesn't care at all about them. In the end it is _intel's_ performance problem and not ours. The problem with that is that the warning goes away and _future_ drivers will probably run into this performance problem and don't know about. -- Greetings Michael. - To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
