Search Linux Wireless

Re: [PATCH] mac80211: fix uninitialized variable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 28, 2013 at 12:28 PM, Sedat Dilek <sedat.dilek@xxxxxxxxx> wrote:
> On Thu, Mar 28, 2013 at 10:21 AM, Johannes Berg
> <johannes@xxxxxxxxxxxxxxxx> wrote:
>> On Thu, 2013-03-28 at 10:11 +0100, Vincent wrote:
>>> Fix one code path where chanctx_conf is tested as being non-NULL while it may
>>> be uninitialized.
>>
>> No, you're wrong, presumably misled by the compiler.
>>
>
> Hi,
>
> especially, when you use gcc >=4.7.x compiler with "-Os"
> optimize-level you and your binaries/libs get confused.
> Arnd Bergmann sent a patch for these "false-positives" (use
> "-Wmaybe-uninitialized" as a CFLAGS).
> I think this is a good idea.
> If more kernel-developers ACK it, it might get mainline :-)?
> Gogogo johill (but don't runaway) :-)...
>
> For more details see also gcc-docs on how to suppress errors and treat
> them as warnings [1].
>
> Regards,
> - Sedat -
>
> [1] http://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#Warning-Options
>

Uuurgh, forgot to add the link for Arnd's patch....

- Sedat -

[2] https://patchwork.kernel.org/patch/2274041/

>> johannes
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
>> the body of a message to majordomo@xxxxxxxxxxxxxxx
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux