Hi Waldemar, On Fri, Mar 22, 2013 at 11:38:57AM +0100, Rymarkiewicz Waldemar wrote: > Hi, > > >> > >>kfree_skb call is used internally by the kernel. A driver should use dev_kfree_skb instead, I guess. > > > >It seems that dev_kfree_skb() call when dev_alloc_skb() is used, and > >kfree_skb() use to free skb malloced by alloc_skb(). > > I agree. The driver should use dev_* flavoured skb function then. I'd prefer the driver to call nfc_alloc_recv_skb() instead. This one calls alloc_skb() but we could have it call dev_alloc_skb() I suppose. dev_alloc_skb does atomic allocation though. And kfree_skb() or dev_kfree_skb() is essentially the same. I'll fix the driver so that it calls nfc_alloc_recv_skb() and kfree_skb unless Wei beats me at it. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
