On Thu, 2008-01-24 at 13:53 -0500, John W. Linville wrote: > Overall this looks fine to me for initial merge. I have a couple > of comments: > > -- I'm not too excited about the "Ndis_802_*" naming scheme for > data structures, although I know you copied it from elsewhere. > I'd like to see it changed, but I don't consider that a > merge blocker. To be honest I'm not either, but I'll prioritise this for later. > -- I foresee this driver surviving a conversion to use the > new cfg80211 configuraiton API. So the "rndis_wext" name may > not be the best long-term choice. I might suggest something > like "rndis_wlan". I don't see why we couldn't change that > post-merge, although I would prefer to do that before the > final 2.6.25 release. Sure. > So, I intend to push this upstream for 2.6.25. Please consider making > the changes cited above, especially the name change. Ok, I'll make new patchset with name change and changes David Brownell wants on usbnet patches. - Jussi - To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
