On Thu, Jan 24, 2008 at 12:27:03PM -0800, Linus Torvalds wrote: > > > On Tue, 8 Jan 2008, Michael Buesch wrote: > > > > > > > > Can you check if that is the > > > > WARN_ON_ONCE(((unsigned long)(skb->data + hdrlen)) & 3); > > > > in rx.c line 1486? > > > > Yes fine. > > Patches are on their way. Ignore the warning for now. It is harmless. > > I don't think this ever got fixed. > > I don't see any alternative but just uncomment that bogus warning, because > it's otherwise going to just cause way more noise than it's worth. It's > apparently known to developers, and as such it's worthless in the source > code except as a way to make poor users worry. > > It's been in the top oops/warnings report for the last three weeks, and I > haven't gotten any patches for it, so I'm a bit grumpy. What's the point > of having a WARN_ON() if nobody involved *does* anything about it? We've been trying to shame the iwlwifi team into fixing it. They have been blaming their firmware, but I think they could fix the alignment in their driver. There is no great harm in reverting 81100eb80add328c4d2a377326f15aa0e7236398 if you would like to go ahead and push the 2.6.24 release. I suspect, however, that the mac80211 guys would like to keep it (or put it back for 2.6.25) to continue to shame driver developers in the future. John -- John W. Linville linville@xxxxxxxxxxxxx - To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
