Search Linux Wireless

Re: [PATCH -next] wireless: remove unused including <linux/version.h>

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/11/2013 09:46 AM, Wei Yongjun wrote:
From: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx>

Remove including <linux/version.h> that don't need it.

Signed-off-by: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx>
---
  drivers/net/wireless/ath/wil6210/cfg80211.c | 1 -
  1 file changed, 1 deletion(-)

diff --git a/drivers/net/wireless/ath/wil6210/cfg80211.c b/drivers/net/wireless/ath/wil6210/cfg80211.c
index 116f4e8..58ce52c 100644
--- a/drivers/net/wireless/ath/wil6210/cfg80211.c
+++ b/drivers/net/wireless/ath/wil6210/cfg80211.c
@@ -21,7 +21,6 @@
  #include <linux/wireless.h>
  #include <linux/ieee80211.h>
  #include <linux/slab.h>
-#include <linux/version.h>
  #include <net/cfg80211.h>

  #include "wil6210.h"

Your patch should be OK. No built-in driver ever needs to check the kernel version.

Your subject is not very good. Usually, the subject starts with the driver name, not the subsystem. Thus if should have been "[PATCH ...] wil6210: ...." or "[PATCH ...] ath: wil6210: ....". With this change, a search using 'git log' will find that wil6210 was modified here. In your version, that info is missing.

Larry


--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux