Dan Carpenter <dan.carpenter@xxxxxxxxxx> writes:
> Hello Kalle Valo,
>
> The patch bdcd81707973: "Add ath6kl cleaned up driver" from Jul 18,
> 2011, leads to the following static checker warning:
> "drivers/net/wireless/ath/ath6kl/txrx.c:1327 ath6kl_rx()
> warn: what are we testing here?"
>
> [ This is from a failed experiment with Smatch that I won't release. ]
[...]
> 1327 if (status || !(skb->data + HTC_HDR_LENGTH)) {
> ^^^^^^^^^^^^^^^^^^^^^^^^^^
> skb->data is a pointer. This pointer math is always going to be false.
> Should it be testing "packet->act_len < HTC_HDR_LENGTH" or something?
Good find! I have no idea what this is supposed to test, but act_len <
HTC_HDR_LENGTH seems like a good idea. I sent a patch for this.
--
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
