2013/3/8 Stanislaw Gruszka <sgruszka@xxxxxxxxxx>:
>> + /*
>> + * FixMe: Why POWER_BOUND and FREQ_OFFSET_BOUND not init here?
>> + */
> ???
Sorry! Patch created only for discussion. I not sure in my my
code.Final patch some later.
> Do we also need to init RF_R17 ? Does vendor driver do this ?
Yes. Function NICInitRT3070RFRegisters in vendor rt3070.c content next code:
if (IS_RT3071(pAd))
{
/* RF power sequence setup, load RF normal operation-mode setup */
RT30xxLoadRFNormalModeSetup(pAd);
}
else if (IS_RT3070(pAd))
{
/* TX_LO1_en, RF R17 register Bit 3 to 0 */
RT30xxReadRFRegister(pAd, RF_R17, &RFValue);
RFValue &= (~0x08);
/* to fix rx long range issue */
if (pAd->NicConfig2.field.ExternalLNAForG == 0)
{
if ((IS_RT3071(pAd) && ((pAd->MACVersion & 0xffff) >= 0x0211))
|| IS_RT3070(pAd))
{
RFValue |= 0x20;
}
}
/* set RF_R17_bit[2:0] equal to EEPROM setting at 0x48h */
if (pAd->TxMixerGain24G >= 1)
{
RFValue &= (~0x7); /* clean bit [2:0] */
RFValue |= pAd->TxMixerGain24G;
}
RT30xxWriteRFRegister(pAd, RF_R17, RFValue);
and function VOID RT30xxLoadRFNormalModeSetup in vendor rt30xx.c
/* TX_LO1_en, RF R17 register Bit 3 to 0*/
RT30xxReadRFRegister(pAd, RF_R17, &RFValue);
RFValue &= (~0x08);
/* to fix rx long range issue*/
if (((pAd->MACVersion & 0xffff) >= 0x0211) &&
(pAd->NicConfig2.field.ExternalLNAForG == 0))
{
RFValue |= 0x20;
}
/* set RF_R17_bit[2:0] equal to EEPROM setting at 0x48h*/
if (pAd->TxMixerGain24G >= 2)
{
RFValue &= (~0x7); /* clean bit [2:0]*/
RFValue |= pAd->TxMixerGain24G;
}
RT30xxWriteRFRegister(pAd, RF_R17, RFValue);
But 0x5f for RF_R17... I'm insure.
>> I also found function rt2800_config_channel_rf2xxx without
>> initialisation POWER_BOUND and FREQ_OFFSET_BOUND. May be this also
>> incorrect?
> Not sure, need to check on old vendor driver.
OK. In final patch i don't touch rt2xxx code. I don't have cards with
RT2xxx chips and can't check this in hardwae.
--
Alex A. Mihaylov
AKA MinimumLaw
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
