On Tue, 2013-03-05 at 18:38 +0200, Kalle Valo wrote:
> Printin the firmware capabilities during the first firmware boot makes it easier to find out what
> features firmware supports.
[]
> diff --git a/drivers/net/wireless/ath/ath6kl/init.c b/drivers/net/wireless/ath/ath6kl/init.c
[]
> +static void ath6kl_init_fw_capas(struct ath6kl *ar, char *buf, size_t buf_len)
> +{
[]
> + if (buf_len - len < 4) {
> + ath6kl_warn("firmware capability buffer too small!\n");
> + strncpy(buf, "<error>", buf_len);
4 is an odd size to use.
It seems weird to overwrite the known bits.
why not just add ...?
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
