On Wed, Feb 27, 2013 at 1:39 PM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Wed, 2013-02-27 at 13:37 +0100, Gertjan van Wingerde wrote: >> Hi Felix, >> >> On Tue, Feb 26, 2013 at 4:09 PM, Felix Fietkau <nbd@xxxxxxxxxxx> wrote: >> > If CONFIG_MAC80211_MESH is not set, cfg80211 will now allow advertising > > typo: "will not allow" > >> > interface combinations with NL80211_IFTYPE_MESH_POINT present. >> > Add appropriate ifdefs to avoid running into errors. >> >> I'm not sure if rt2x00 is the proper place to fix this. To me it >> doesn't look good to have to sprinkle these kind of ifdefs throughout >> the drivers to check if mac80211 has mesh enabled. >> I would prefer a solution where drivers are still able to indicate >> that they support mesh interfaces, but where mac80211/cfg80211 prevent >> these kind of interfaces from being created. >> >> @Johannes: What is your view on this? > > It would be nicer, but the data is const so mac80211 can't modify it, > and I don't see that we should add a lot of code/handshaking to > mac80211/cfg80211 just to avoid one ifdef here. > OK. No worries. Was just looking if there was an alternative. I'll ack Felix' patch then -- --- Gertjan -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
