On Tue, Feb 26, 2013 at 09:44:00PM +0100, Johannes Berg wrote: > More generally, does this really make much sense? There are other things > here, e.g. ieee80211_configure_filter(), ieee80211_recalc_ps(), > ieee80211_hw_config() and probably more that can be executed in this > function -- I don't think protecting these two calls is really > sufficient? Seems all other drv calls like those on ieee80211_confgure_fitler() do not require sdata. So this is most likely sufficient. I'm able to reporduce warnings on rt2x00 usb with commit 761ce8c41ed20ee3af77f2df527edc3f92e6f3bf reverted. This patch make them gone. Stanislaw -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html