Search Linux Wireless

Re: b43legacy: fix MAC control and microcode init

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wednesday 23 January 2008 14:48:50 Stefano Brivio wrote:
> This zeros out all microcode related memory before loading
> the microcode.
> 
> This also fixes initialization of the MAC control register.
> The _only_ place where we overwrite the contents of the MAC control
> register is at the beginning of b43_chip_init().
> All other places must do read() -> mask/set -> write() to not
> overwrite existing bits.
> 
> This also adds a longer delay for waiting for the microcode
> to initialize itself. It seems that the current timeout is sufficient
> on all available devices, but there's no real reason why we shouldn't
> wait for up to one second. Slow embedded devices might exist.
> Better safe than sorry.
> 
> While at it, fix naming of MACCTL values.
> 
> This patch by Michael Buesch has been ported to b43legacy.
> 
> Cc: Michael Buesch <mb@xxxxxxxxx>
> Signed-off-by: Stefano Brivio <stefano.brivio@xxxxxxxxx>
> ---

Acked-by: Michael Buesch <mb@xxxxxxxxx>

> John, this bugfix should go into 2.6.24, if possible.

We agreed in private that this is actually pretty intrusive and
the patches should _not_ go into 2.6.24, as they don't actually
fix known bugs.

-- 
Greetings Michael.
-
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux