On Mon, 2013-02-18 at 17:08 +0100, Marco Porsch wrote:
> + /*
> + * If available, calculate the time the beacon timestamp field was
> + * received from the rx_status->mactime field. Otherwise get the
> + * current TSF as approximation before entering rcu-read section.
> + */
> + if (ieee80211_have_rx_timestamp(rx_status))
> + t_r = ieee80211_calculate_rx_timestamp(local, rx_status,
> + 24 + 12 +
> + elems->total_len +
> + FCS_LEN,
> + 24);
That doesn't seem right -- it's calculating the timestamp at the end of
the frame, but you said you wanted the timestamp at the "timestamp
field" time, which is just 24 bytes into the frame.
> +static void mesh_sync_offset_rx_bcn(struct sta_info *sta,
> + struct ieee80211_mgmt *mgmt,
> + struct ieee802_11_elems *elems,
> + u64 t_r)
> {
> + struct ieee80211_sub_if_data *sdata = sta->sdata;
> struct ieee80211_if_mesh *ifmsh = &sdata->u.mesh;
> - struct ieee80211_local *local = sdata->local;
> - struct sta_info *sta;
> - u64 t_t, t_r;
> + u64 t_t;
>
> WARN_ON(ifmsh->mesh_sp_id != IEEE80211_SYNC_METHOD_NEIGHBOR_OFFSET);
>
> /* standard mentions only beacons */
> - if (stype != IEEE80211_STYPE_BEACON)
> + if (!ieee80211_is_beacon(mgmt->frame_control))
> return;
This is a bit odd -- why should a function that's called _rx_bcn() have
to check it? Seems the check should be outside the API boundary.
> - if (ieee80211_have_rx_timestamp(rx_status))
> - /* time when timestamp field was received */
> - t_r = ieee80211_calculate_rx_timestamp(local, rx_status,
> - 24 + 12 +
> - elems->total_len +
> - FCS_LEN,
> - 24);
I see this was already wrong ...
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
