Search Linux Wireless

RE: [PATCH 1/2] mwifiex: coding style cleanup in bss parameter update

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Joe,

Thanks for your comment.

> On Fri, 2013-02-15 at 21:44 -0800, Bing Zhao wrote:
> > From: Yogesh Ashok Powar <yogeshp@xxxxxxxxxxx>
> > They all can make one line.
> []
> > diff --git a/drivers/net/wireless/mwifiex/scan.c b/drivers/net/wireless/mwifiex/scan.c
> []
> > @@ -1485,20 +1485,15 @@ static int mwifiex_update_curr_bss_params(struct mwifiex_private *priv,
> >  	priv->curr_bss_params.bss_descriptor.bcn_wapi_ie = NULL;
> >  	priv->curr_bss_params.bss_descriptor.wapi_offset = 0;
> >  	priv->curr_bss_params.bss_descriptor.bcn_ht_cap = NULL;
> > -	priv->curr_bss_params.bss_descriptor.ht_cap_offset =
> > -		0;
> > +	priv->curr_bss_params.bss_descriptor.ht_cap_offset = 0;
> 
> Another way to do this to reduce the visual noise it to
> create a temporary
> 	struct mwifiex_bssdescriptor *t = &priv->curr_bss_params.bss_descriptor;
> and use
> 	s/priv->curr_bss_params.bss_descriptor./t->/

This does look better.

As the patch is in wireless-next now I can make the change later.

Thanks,
Bing
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux