On Mon, 2013-02-18 at 11:24 -0600, Larry Finger wrote: > On 02/18/2013 08:02 AM, Johannes Berg wrote: > > From: Johannes Berg <johannes.berg@xxxxxxxxx> > > > > Larry noticed (and bisected) that commit df881293c6ba9a12868491a717b25 > > "cfg80211: Pass TDLS peer's QoS/HT/VHT information during set_station" > > broke secure connections. This is is the case only for drivers that > > don't support TDLS, where any kind of change, even just the change of > > authorized flag that is required for normal operation, was rejected > > now. To fix this, remove the checks. I have some patches that will add > > proper verification for all the different cases later. > > > > Cc: Jouni Malinen <j@xxxxx> > > Bisected-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx> > > Signed-off-by: Johannes Berg <johannes.berg@xxxxxxxxx> > > Johannes, > > Thanks. This patch does fix the problem. The only thing I saw was an unused > variable: > > net/wireless/nl80211.c: In function ‘nl80211_set_station_tdls’: > net/wireless/nl80211.c:3421:37: warning: unused variable ‘rdev’ [-Wunused-variable] > > Tested-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx> Thanks, I'll fix that variable and apply the patch. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html