2013/2/16 Hauke Mehrtens <hauke@xxxxxxxxxx>:
> The mac address should be aligned to u16 to prevent an unaligned access
> in drivers/ssb/pci.c where it is casted to __be16.
>
> Signed-off-by: Hauke Mehrtens <hauke@xxxxxxxxxx>
> ---
> include/linux/ssb/ssb.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/ssb/ssb.h b/include/linux/ssb/ssb.h
> index 22958d6..457e8eb 100644
> --- a/include/linux/ssb/ssb.h
> +++ b/include/linux/ssb/ssb.h
> @@ -26,6 +26,7 @@ struct ssb_sprom_core_pwr_info {
>
> struct ssb_sprom {
> u8 revision;
> + u8 country_code; /* Country Code */
> u8 il0mac[6]; /* MAC address for 802.11b/g */
It looks a little hacky to me too, it's easy to forget about that
requirement and break that again in the future.
What about not casting il0mac to u16 at all? Maybe we should just fill
it as u8 (which it is)?
--
Rafał
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
