I still get the warning when building wireless-next on my F17 box with this patch applied... On Fri, Feb 15, 2013 at 10:52:21AM +0100, Stanislaw Gruszka wrote: > This should fix: > > drivers/net/wireless/iwlegacy/4965-mac.c:1847:33: warning: 'phys_addr' may be used uninitialized in this function [-Wmaybe-uninitialized] > > Reported-by: Fengguang Wu <fengguang.wu@xxxxxxxxx> > Signed-off-by: Stanislaw Gruszka <sgruszka@xxxxxxxxxx> > --- > drivers/net/wireless/iwlegacy/4965-mac.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/iwlegacy/4965-mac.c b/drivers/net/wireless/iwlegacy/4965-mac.c > index 7941eb3..d2ab1cf 100644 > --- a/drivers/net/wireless/iwlegacy/4965-mac.c > +++ b/drivers/net/wireless/iwlegacy/4965-mac.c > @@ -1843,7 +1843,7 @@ il4965_tx_skb(struct il_priv *il, > il->ops->txq_attach_buf_to_tfd(il, txq, txcmd_phys, firstlen, 1, 0); > dma_unmap_addr_set(out_meta, mapping, txcmd_phys); > dma_unmap_len_set(out_meta, len, firstlen); > - if (secondlen) > + if (secondlen > 0) > il->ops->txq_attach_buf_to_tfd(il, txq, phys_addr, secondlen, > 0, 0); > > -- > 1.7.11.7 > > -- John W. Linville Someday the world will need a hero, and you linville@xxxxxxxxxxxxx might be all we have. Be ready. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
