Search Linux Wireless

Re: [PATCH 1/3] mac80211: move mesh sync beacon handler into neighbour_update

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Feb 15, 2013 at 01:14:59PM +0100, Johannes Berg wrote:
> On Fri, 2013-02-15 at 12:40 +0100, Marco Porsch wrote:
> 
> > -	/* The current tsf is a first approximation for the timestamp
> > -	 * for the received beacon.  Further down we try to get a
> > -	 * better value from the rx_status->mactime field if
> > -	 * available. Also we have to call drv_get_tsf() before
> > -	 * entering the rcu-read section.*/
> 
> I don't think you should drop this comment; also why not just address
> it? There's a timestamp in rx_status that should be the correct one for
> ath9k (which is pretty much all this seems to work on anyway :) )

The comment is just moved?  Mesh already uses rx_status->mactime, if
the driver supplies it, which the comment says :)

-- 
Bob Copeland %% www.bobcopeland.com
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux