Hi,
> diff --git a/drivers/net/wireless/rt2x00/rt2x00debug.c b/drivers/net/wireless/rt2x00/rt2x00debug.c
> index 3bb8caf..f6776b1 100644
> --- a/drivers/net/wireless/rt2x00/rt2x00debug.c
> +++ b/drivers/net/wireless/rt2x00/rt2x00debug.c
> @@ -86,6 +86,7 @@ struct rt2x00debug_intf {
> struct dentry *csr_val_entry;
> struct dentry *eeprom_off_entry;
> struct dentry *eeprom_val_entry;
> + struct dentry *eeprom_commit_entry;
This is incorrect, all other debugfs files are read/write, so there is
no point in a extra commit file.
> @@ -650,6 +651,37 @@ static struct dentry *rt2x00debug_create_file_chipset(const char *name,
> return debugfs_create_blob(name, S_IRUSR, intf->driver_folder, blob);
> }
>
> +#include "rt2800lib.h"
So here we make the _generic_ rt2x00lib module be specific for rt2800 only.
That is a terrible idea.
> +static ssize_t rt2x00debug_eeprom_commit_write(struct file *file,
> + const char __user *buf,
> + size_t length,
> + loff_t *offset)
> +{
> + struct rt2x00debug_intf *intf = file->private_data;
> +
> + rt2800_write_eeprom(intf->rt2x00dev);
> + return length;
> +}
> +static ssize_t rt2x00debug_eeprom_commit_read(struct file *file,
> + char __user *buf,
> + size_t length,
> + loff_t *offset)
> +{
> + struct rt2x00debug_intf *intf = file->private_data;
> +
> + rt2800_read_eeprom(intf->rt2x00dev);
> + return 0;
> +}
rt2800 specific code doesn't belong in the generic code. You should
make your solution
completely driver independent.
> /**
> + * rt2x00usb_eeprom_write - Write eeprom to device
> + * @rt2x00dev: Pointer to &struct rt2x00_dev
> + * @eeprom: Pointer to eeprom array to copy the information from
> + * @length: Number of bytes to write to the eeprom
> + *
> + * Simple wrapper around rt2x00usb_vendor_request to write the eeprom
> + * to the device. Note that the eeprom argument _must_ be allocated using
> + * kmalloc for correct handling inside the kernel USB layer.
> + */
> +static inline int rt2x00usb_eeprom_write(struct rt2x00_dev *rt2x00dev,
> + __le16 *eeprom, const u16 length)
> +{
> + return rt2x00usb_vendor_request(rt2x00dev, USB_EEPROM_WRITE,
> + USB_VENDOR_REQUEST_OUT, 0, 0,
> + eeprom, length,
> + REGISTER_TIMEOUT16(length));
> +}
Have you checked if this is specific to rt2800 or would other Ralink USB devices
be able to work with this as well?
Ivo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
