On Thu, Feb 14, 2013 at 3:18 AM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Wed, 2013-02-13 at 12:14 -0800, Thomas Pedersen wrote: >> Previously, the entire mesh beacon would be generated each >> time the beacon timer fired. Instead generate a beacon >> head and tail (so the TIM can easily be inserted when mesh >> power save is on) when starting a mesh or the MBSS >> parameters change. >> >> Also add a mutex for protecting beacon updates and >> preventing leaks. > > And I dropped the patch again due to a sparse warning (with RCU sparse > enabled in Kconfig): That's handy, I'll keep it enabled in the future. > net/mac80211/mesh.c:836:9: warning: incorrect type in argument 1 (different address spaces) > net/mac80211/mesh.c:836:9: expected struct callback_head *head > net/mac80211/mesh.c:836:9: got struct callback_head [noderef] <asn:4>*<noident> > > (btw, should there be locking there in that function?) I think all timers, work, etc. should be stopped at that point, but I guess it couldn't hurt. -- Thomas -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
