Hi Johannes,
> On Mon, 2013-02-11 at 23:56 -0800, Bing Zhao wrote:
> > From: Amitkumar Karwar <akarwar@xxxxxxxxxxx>
> >
> > If user knows the location of a wowlan pattern to be matched in
> > Rx packet, he can provide an offset with the pattern. This will
> > help drivers to ignore initial bytes and match the pattern
> > efficiently.
>
> This is a bit tricky. Right now, the documentation says:
>
> * @NL80211_WOWLAN_TRIG_PKT_PATTERN: wake up on the specified packet patterns
> * which are passed in an array of nested attributes, each nested attribute
> * defining a with attributes from &struct nl80211_wowlan_trig_pkt_pattern.
> * Each pattern defines a wakeup packet. The matching is done on the MSDU,
> * i.e. as though the packet was an 802.3 packet, so the pattern matching
> * is done after the packet is converted to the MSDU.
>
> I don't mind adding the offset, but not all devices will support that
> (ours doesn't) so when advertising the feature it needs to be documented
> to be something like the maximum possible offset? So you also need to
> modify the documentation for that and the code in nl80211_send_wiphy().
>
> > @@ -7070,7 +7073,8 @@ static int nl80211_set_wowlan(struct sk_buff *skb, struct genl_info *info)
> > nla_data(pat), nla_len(pat), NULL);
> > err = -EINVAL;
> > if (!pat_tb[NL80211_WOWLAN_PKTPAT_MASK] ||
> > - !pat_tb[NL80211_WOWLAN_PKTPAT_PATTERN])
> > + !pat_tb[NL80211_WOWLAN_PKTPAT_PATTERN] ||
> > + !pat_tb[NL80211_WOWLAN_PKTPAT_OFFSET])
> > goto error;
>
> You can't just break backward compatibility like that, the new attribute
> must be optional and assumed 0 if it's not present.
>
> > @@ -7096,6 +7100,8 @@ static int nl80211_set_wowlan(struct sk_buff *skb, struct genl_info *info)
> > memcpy(new_triggers.patterns[i].pattern,
> > nla_data(pat_tb[NL80211_WOWLAN_PKTPAT_PATTERN]),
> > pat_len);
> > + new_triggers.patterns[i].pkt_offset = nla_get_u32(
> > + pat_tb[NL80211_WOWLAN_PKTPAT_OFFSET]);
>
> Since all existing users of the API would ignore the pkt_offset, you
> must reject the configuration if the offset exceeds the maximum
> permissible offset the device advertises (existing ones would advertise
> 0)
Thanks for your comments.
The revised v2 patch has been submitted. Please review.
Regards,
Bing
��.n��������+%������w��{.n�����{���zW����ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
