Search Linux Wireless

Re: [PATCHv2 1/1] mac80211: fix WPA with VLAN on AP side with ps-sta

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2013-02-12 at 18:42 +0100, michael-dev wrote:

> >> -		if (!ieee80211_tx_prepare(sdata, &tx, skb))
> >> +		frame_sdata = IEEE80211_DEV_TO_SUB_IF(skb->dev);
> >> +		if (!ieee80211_tx_prepare(frame_sdata, &tx, skb))
> >>  			break;
> > 
> > This can now crash the machine.
> 
> why? when?

There's no guarantee that the VLAN interface isn't destroyed while the
frame is stuck on the buffer queue.

> What would be a better approach?

This is probably fine, but incomplete -- frames for a VLAN need to be
removed from the PS queue when it goes down.

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux