On Mon, 2013-02-11 at 13:53 -0500, Solomon Peachy wrote: > On Fri, Feb 08, 2013 at 05:15:59PM -0800, Joe Perches wrote: > > Could you please run your patches through > > scripts/checkpatch.pl --strict > > If you think it's bad now, you should have seen the state of the code > when I first "inherited" it. :) No doubt, but that wasn't my point. > Question -- as a matter of policy, is the goal to have a completely > clean checkpatch run? I get that there should be no ERRORs, but > WARNINGs/CHECKs are not considered fatal for a reason, right? No. It's just a guideline. As far as I'm concerned, ignore every checkpatch message you don't agree with. Just be aware that there's a tool to help you get your code looking more like what most others generally consider "kernel style". Though when you add "new" code, stuff like > + u32 sdio_reg_addr_17bit ; is untidy because of the space before the semicolon. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
