On 02/07/2013 08:35 PM, Tim Gardner wrote:
> DOT11_MIN_BEACON_PERIOD and DOT11_MAX_BEACON_PERIOD are
> superfluous. The only invalid beacon period is 0. Comparing
> a 16 bit quantity to 0xffff also causes a compile warning:
>
> drivers/net/wireless/brcm80211/brcmsmac/main.c:5560 brcms_c_set_beacon_period()
> warn: impossible condition '(period > 65535) => (0-65535 > 65535)'
>
> Observed from smatch analysis.
>
> Cc: Brett Rudley <brudley@xxxxxxxxxxxx>
> Cc: "Franky (Zhenhui) Lin" <frankyl@xxxxxxxxxxxx>
> Cc: Hante Meuleman <meuleman@xxxxxxxxxxxx>
> Cc: "John W. Linville" <linville@xxxxxxxxxxxxx>
> Cc: Pieter-Paul Giesberts <pieterpg@xxxxxxxxxxxx>
> Cc: Seth Forshee <seth.forshee@xxxxxxxxxxxxx>
> Cc: Hauke Mehrtens <hauke@xxxxxxxxxx>
> Cc: linux-wireless@xxxxxxxxxxxxxxx
> Cc: brcm80211-dev-list@xxxxxxxxxxxx
> Cc: netdev@xxxxxxxxxxxxxxx
Acked-by: Arend van Spriel <arend@xxxxxxxxxxxx>
> Signed-off-by: Tim Gardner <tim.gardner@xxxxxxxxxxxxx>
> ---
> drivers/net/wireless/brcm80211/brcmsmac/main.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/net/wireless/brcm80211/brcmsmac/main.c b/drivers/net/wireless/brcm80211/brcmsmac/main.c
> index c26992a..080b54d 100644
> --- a/drivers/net/wireless/brcm80211/brcmsmac/main.c
> +++ b/drivers/net/wireless/brcm80211/brcmsmac/main.c
> @@ -101,8 +101,6 @@
> #define DOT11_RTS_LEN 16
> #define DOT11_CTS_LEN 10
> #define DOT11_BA_BITMAP_LEN 128
> -#define DOT11_MIN_BEACON_PERIOD 1
> -#define DOT11_MAX_BEACON_PERIOD 0xFFFF
> #define DOT11_MAXNUMFRAGS 16
> #define DOT11_MAX_FRAG_LEN 2346
>
> @@ -5555,8 +5553,7 @@ int brcms_c_set_rateset(struct brcms_c_info *wlc, struct brcm_rateset *rs)
>
> int brcms_c_set_beacon_period(struct brcms_c_info *wlc, u16 period)
> {
> - if (period < DOT11_MIN_BEACON_PERIOD ||
> - period > DOT11_MAX_BEACON_PERIOD)
> + if (period == 0)
> return -EINVAL;
>
> wlc->default_bss->beacon_period = period;
>
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
