Re: [PATCHv8 3/3] nl80211: allow DFS in start_ap

[Simon Wunderlich <simon.wunderlich@xxxxxxxxxxxxxxxxxxxx>]

On Wed, Feb 06, 2013 at 06:36:20PM +0100, Johannes Berg wrote:
> On Mon, 2013-02-04 at 13:49 +0100, Simon Wunderlich wrote:
> 
> > +	err = cfg80211_chandef_dfs_required(wdev->wiphy, &params.chandef);
> > +	if (err < 0)
> > +		return -EINVAL;
> 
> return err; ?
> 
OK
> > +	if (err) {
> > +		radar_detect_width = BIT(params.chandef.width);
> > +		params.radar_required = true;
> 
> It seems you should probably just squash this into patch 1 since you
> already use it in mac80211 in patch 2 but only patch 3 makes it valid?
> seems a bit odd

Yeah, patch 1 was becoming bigger and patch 3 smaller ... will just
squash it.

Thanks,
	Simon

Attachment: signature.asc
Description: Digital signature