Search Linux Wireless

Re: [PATCH 2/3] mac80211: generate mesh probe requests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 4, 2013 at 9:38 AM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote:
> On Sat, 2013-02-02 at 17:02 -0800, Thomas Pedersen wrote:
>
>> -     pos = skb_put(skb, ie_ssid_len);
>> -     *pos++ = WLAN_EID_SSID;
>> +     if (ieee80211_vif_is_mesh(vif)) {
>> +             pos = skb_put(skb, 2 + 2 + ssid_len);
>> +             *pos++ = WLAN_EID_SSID;
>> +             *pos++ = 0;
>> +             /* NOTE: mesh ID will be out of order */
>
> Why put it out of order?
>
> Also I'm not convinced that it's a good idea to translate "SSID" from
> the userspace API to "mesh ID" silently? Might make more sense to have
> those separately maybe? I mean, it seems reasonable to even think you
> might scan for a mesh network when you're not a mesh interface, for
> example?

Yeah that makes more sense,  but will obviously require more work.
I'll just drop this for now.

-- 
Thomas
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux