On 01/31/2013 06:44 PM, Simon Wunderlich wrote: > On Thu, Jan 31, 2013 at 05:46:00PM +0100, Johannes Berg wrote: >> On Thu, 2013-01-31 at 17:13 +0100, Simon Wunderlich wrote: >> [...] >> >> Maybe so, I just don't think you need the time there since it won't be >> of relevance in the USABLE state. The "state entered" time is only used >> for UNAVAILABLE. >> >> Maybe therefore state_entered should be renamed to "unavailable_until" >> with the corresponding change in the logic of adding the time when it's >> set to that state? > > Can do that, if no one is interested in when we, say, change from unavailable > to usable (after NOP). This is what Zefir asked for. > My assumption was that the user (or the certification lab engineer) might want to know how long the device is going to remain in CAC. And since a time-stamp must be kept anyhow for NOP, with the (channel_state / ts) tuple everything needed to track the state transition is already there. Otherwise, it is not needed. > Personally I don't care at all, and we discuss that in the cover letter thread > anyway. Let's see what Zefir says or if anyone else objects, I put that onto > the "TODO if nobody objects list". :) > No objections here. The updated concept makes my work already way easier to handle, and since I need to implement a frequency manager / planner anyhow on higher layers, there's no need to consider my comments unless they are relevant for stand-alone operation. > Thanks! > Simon > -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html