On Tue, 2013-01-29 at 17:47 -0600, Seth Forshee wrote:
> + if (offchan_tx_ok) {
unlikely(), this is one of the hottest code paths in mac80211 after
all :-)
> + /*
> + * Always directly transmit off-channel frames
> + * unless the driver has stopped the queues.
> + */
> + if (test_bit(IEEE80211_QUEUE_STOP_REASON_DRIVER,
> + &local->queue_stop_reasons[q])) {
might there be other reasons to TX, i.e. ignore only
STOP_REASON_OFFCHANNEL?
That might be more efficient too:
offchflag = offchan_tx_ok << log2(STOP_REASON_OFFCHANNEL);
> + } else if (local->queue_stop_reasons[q] ||
if (local->queue_stop_reasons[q] & ~offchflag || ...
OTOH, I guess you want a different return value too. But that's in a
relatively unlikely code path again, so might still be better to then
again differentiate within that if.
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
