Search Linux Wireless

[RFC] Expand byte counters in struct station_info

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

Now wifi drivers reports per-station info using struct station_info;
and currently for the data counters it has:
	u32 rx_bytes;
	u32 tx_bytes;

while for device-wide statistics one can use ndo_get_stats64() to fill
64-bit counters in the struct rtnl_link_stats64, per-station statistics
are 32-bit.

This becomes problematic with gigabit speeds now observed for .11ac and .11ad -
counters overflown every few seconds.

I'd like to extend rx and tx byte counters to 64-bit.

What is better - expand existing fields in struct station_info as:
	u64 rx_bytes;
	u64 tx_bytes;
or add ne ones like:
	u64 rx_bytes64;
	u64 tx_bytes64;


Then, I'll add
	NL80211_STA_INFO_RX_BYTES64,
	NL80211_STA_INFO_TX_BYTES64,
to the enum nl80211_sta_info

Before doing patch, I'd like to hear comments.
Any consideration why is this not to be done or done differently?

Thanks, Vladimir
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux