On Wed, Jan 30, 2013 at 10:56:03AM +1100, Julian Calaby wrote:
> Hi Seth,
>
> On Wed, Jan 30, 2013 at 10:47 AM, Seth Forshee
> <seth.forshee@xxxxxxxxxxxxx> wrote:
> > Broadcom hardware sets the value of the PM flag in frame control based
> > on the value of MCTL_HPS, which seems to include actively clearing PM
> > if MCTL_HPS is not set. brcmsmac needs to suppor the off-channel
> > powersave state in order to enable powersave at the AP at all.
> >
> > Add limited support for powersave to brcmsmac to prevent frame loss
> > during background scans. Full powersave supoprt remains unimplemented,
> > but switching between the off-channel and disabled states is possible.
> >
> > Signed-off-by: Seth Forshee <seth.forshee@xxxxxxxxxxxxx>
> > ---
> > .../net/wireless/brcm80211/brcmsmac/mac80211_if.c | 15 +++++++++++----
> > drivers/net/wireless/brcm80211/brcmsmac/main.c | 9 +++++++++
> > drivers/net/wireless/brcm80211/brcmsmac/pub.h | 1 +
> > 3 files changed, 21 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/net/wireless/brcm80211/brcmsmac/main.c b/drivers/net/wireless/brcm80211/brcmsmac/main.c
> > index c26992a..3fb71c9 100644
> > --- a/drivers/net/wireless/brcm80211/brcmsmac/main.c
> > +++ b/drivers/net/wireless/brcm80211/brcmsmac/main.c
> > @@ -7545,6 +7549,11 @@ void brcms_c_set_beacon_listen_interval(struct brcms_c_info *wlc, u8 interval)
> > brcms_c_bcn_li_upd(wlc);
> > }
> >
> > +void brcms_c_set_ps(struct brcms_c_info *wlc)
> > +{
> > + brcms_c_set_ps_ctrl(wlc);
> > +}
> > +
>
> Why not just use brcms_c_set_ps_ctrl() directly?
It's a remnant from an earlier version of the patches. Looks like I just
didn't take things to the logical conclusion when I refactored the code.
Seth
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
