Search Linux Wireless

Re: [PATCH 1/2] cfg80211: refactor hidden SSID finding

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2013-01-30 at 00:45 +0100, Johannes Berg wrote:

> @@ -469,14 +448,9 @@ static int cmp_hidden_bss(struct cfg80211_bss *a, struct cfg80211_bss *b)
>  	ie2 = cfg80211_find_ie(WLAN_EID_SSID, b_ies->data, b_ies->len);
>  
>  	/*
> -	 * Key comparator must use same algorithm in any rb-tree
> -	 * search function (order is important), otherwise ordering
> -	 * of items in the tree is broken and search gives incorrect
> -	 * results. This code uses same order as cmp_ies() does.
> -	 *
> -	 * Note that due to the differring behaviour with hidden SSIDs
> -	 * this function only works when "b" is the tree element and
> -	 * "a" is the key we're looking for.
> +	 * Note that with "hide_ssid", the function returns a match if
> +	 * the already-present BSS ("b") is a hidden SSID beacon for
> +	 * the new BSS ("a").
>  	 */
>  

Need to insert
	if (!ie1 && !ie2)
		return 0;

here.

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux