On Thu, 2013-01-24 at 10:10 +0100, Johannes Berg wrote: > On Thu, 2013-01-24 at 08:46 +0200, Luciano Coelho wrote: > > > > Change-Id: I7766f071273f3e31020395cc74eabcc6d165fa3a > > > As I asked on IRC, what are these Change-Id tags you've been using > > recently? Just curious. > > For gerrit. We use it internally, and I was sending the review patches > from my internal review tree. Usually I strip them when applying to my > kernel tree(s), but sometimes I forget. Okay, fair enough. ;) > > > + * @NL80211_WOWLAN_TRIG_WAKEUP_PKT_8022_LEN: Original length of the 802.3 > > > + * packet, may be bigger than the @NL80211_WOWLAN_TRIG_WAKEUP_PKT_8023 > > > + * attribute if the packet was truncated somewhere. > > > > This seems wrong. Why PKT_8023 and PKT_8022_LEN? > > Yeah, typo. > > > Also, is there any specific reason you want to know the original length? > > Just to check whether the packet was truncated or not? > > Yeah our device has a certain buffer size only (it's pretty large) but > the packet could be truncated due to that, so I added that to be able to > see that truncation. The actual length of the packet is irrelevant isn't it? Maybe a boolean just indicating it's truncated? Not really that important though, just for a bit more clarity. -- Luca. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
